Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ES-1457): mention readinessProbes config requirement in middleware changelog #7373

Conversation

lsliwaradioluz
Copy link
Collaborator

For the /readyz endpoint to work correctly in @vue-storefront/middleware before version 5.3.2, one must pass the readinessProbes: [] configuration to createServer in ./apps/storefront-middleware/src/index.ts. This PR mentions this requirement in the package's changelog as requested by @vladovsiienko

@lsliwaradioluz lsliwaradioluz requested a review from a team as a code owner January 23, 2025 10:53
Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 7da5dbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@lsliwaradioluz lsliwaradioluz requested review from WojtekTheWebDev, vladovsiienko and sethidden and removed request for a team January 23, 2025 10:59
Copy link
Contributor

@sethidden sethidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a note to 5.3.2 that adding readinessProbes is no longer required? It is "sorta" mentioned already but just to be clear I think it can be edited too

@lsliwaradioluz lsliwaradioluz removed the request for review from WojtekTheWebDev January 23, 2025 11:56
@lsliwaradioluz lsliwaradioluz merged commit 1f0ab35 into main Jan 23, 2025
3 checks passed
@lsliwaradioluz lsliwaradioluz deleted the docs/es-1457-add-readyz-readinessProbes-to-middleware-changelog branch January 23, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants