feat: add `@vuepress/bundler-farm` #1583

typed-sigterm · 2024-07-01T06:53:27Z

🚧 Experimental + Work in Progress 🚧

Before submitting the PR, please make sure you do the following

Read the Contributing Guidelines.
Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

Bug fix
New feature
Documentation update
Other

Description

Ref: #1552

coveralls · 2024-07-01T08:04:54Z

Pull Request Test Coverage Report for Build 9739675060

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 38.576%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	0	2	0.0%

Totals
Change from base Build 9656194136:	-0.03%
Covered Lines:	631
Relevant Lines:	1663

💛 - Coveralls

coveralls · 2024-07-01T08:36:47Z

Pull Request Test Coverage Report for Build 9739790629

Details

0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 38.576%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	0	2	0.0%

Totals
Change from base Build 9656194136:	-0.03%
Covered Lines:	631
Relevant Lines:	1663

💛 - Coveralls

Mister-Hope · 2024-07-01T09:03:27Z

Looking forward to it (๑•ૅω•´๑)

coveralls · 2024-07-01T09:09:16Z

Pull Request Test Coverage Report for Build 9740770751

Details

0 of 28 (0.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 38.04%

Changes Missing Coverage	Changed/Added Lines	%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	7	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.6%
Covered Lines:	631
Relevant Lines:	1689

💛 - Coveralls

coveralls · 2024-07-01T09:22:45Z

Pull Request Test Coverage Report for Build 9741133313

Details

0 of 29 (0.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 38.025%

Changes Missing Coverage	Changed/Added Lines	%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.6%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

coveralls · 2024-07-02T06:48:21Z

Pull Request Test Coverage Report for Build 9756258638

Details

0 of 29 (0.0%) changed or added relevant lines in 6 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 38.025%

Changes Missing Coverage	Changed/Added Lines	%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.6%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

coveralls · 2024-07-02T07:05:28Z

Pull Request Test Coverage Report for Build 9756442612

Details

0 of 30 (0.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.6%) to 37.965%

Changes Missing Coverage	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressMainPlugin.ts	1	0.0%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.6%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

meteorlxy

Really interesting. Didn't know farm bundler before. Looking forward to the integration. 👍

.github/workflows/e2e.yml

meteorlxy · 2024-07-02T07:42:56Z

package.json

@@ -39,6 +39,7 @@
    "@vitest/coverage-istanbul": "^1.6.0",
    "bumpp": "^9.4.1",
    "conventional-changelog-cli": "^5.0.0",
+    "core-js": "^3.37.1",


May not put it in root?

Maybe upstream bug/design 🤔 Farm currently starts resolving core-js from each dependency's node_modules, which is a problem when using Monorepo. So put core-js in the root package to ensure core-js can be resolved and not unnecessarily increase the number of dependencies on other packages.

coveralls · 2024-07-05T01:39:38Z

Pull Request Test Coverage Report for Build 9801782315

Details

0 of 30 (0.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 37.935%

Changes Missing Coverage	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressMainPlugin.ts	1	0.0%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.7%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

coveralls · 2024-07-05T01:39:52Z

Pull Request Test Coverage Report for Build 9801773016

Details

0 of 30 (0.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 37.935%

Changes Missing Coverage	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressMainPlugin.ts	1	0.0%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.7%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

coveralls · 2024-07-05T01:47:29Z

Pull Request Test Coverage Report for Build 9801846027

Details

0 of 30 (0.0%) changed or added relevant lines in 7 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.7%) to 37.935%

Changes Missing Coverage	Changed/Added Lines	%
packages/vite-kit/src/plugins/vuepressMainPlugin.ts	1	0.0%
packages/bundler-farm/src/resolveFarmConfig.ts	2	0.0%
packages/vite-kit/src/plugins/vuepressVuePlugin.ts	2	0.0%
packages/bundler-farm/src/farmBundler.ts	3	0.0%
packages/bundler-farm/src/plugins/vuepressUserConfigPlugin.ts	3	0.0%
packages/bundler-farm/src/dev.ts	8	0.0%
packages/bundler-farm/src/build.ts	11	0.0%

Totals
Change from base Build 9656194136:	-0.7%
Covered Lines:	631
Relevant Lines:	1690

💛 - Coveralls

typed-sigterm · 2024-07-05T02:07:01Z

This PR may take longer to complete. Vite SSR and Farm SSR are not very similar :(

typed-sigterm force-pushed the feat/farm-bundler branch from c2912e3 to cca3081 Compare July 1, 2024 07:02

refactor(bundler-vite): extract public logic to @vuepress/vite-kit

ca5f969

typed-sigterm force-pushed the feat/farm-bundler branch from cca3081 to ca5f969 Compare July 1, 2024 07:11

typed-sigterm force-pushed the feat/farm-bundler branch from 68a167a to b5f9e46 Compare July 1, 2024 08:48

typed-sigterm force-pushed the feat/farm-bundler branch from b5f9e46 to 01c47d9 Compare July 2, 2024 06:45

typed-sigterm force-pushed the feat/farm-bundler branch from 01c47d9 to e1c8909 Compare July 2, 2024 07:02

meteorlxy reviewed Jul 2, 2024

View reviewed changes

typed-sigterm force-pushed the feat/farm-bundler branch 2 times, most recently from 5c5b0bd to c9af9f6 Compare July 5, 2024 01:35

feat(bundler-farm): mvp

17bb454

typed-sigterm force-pushed the feat/farm-bundler branch from c9af9f6 to 17bb454 Compare July 5, 2024 01:45

meteorlxy force-pushed the main branch from a0da533 to 5709c57 Compare September 12, 2024 18:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `@vuepress/bundler-farm` #1583

feat: add `@vuepress/bundler-farm` #1583

typed-sigterm commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

Mister-Hope commented Jul 1, 2024

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

meteorlxy left a comment

meteorlxy Jul 2, 2024

typed-sigterm Jul 5, 2024

coveralls commented Jul 5, 2024 •

edited

Loading

coveralls commented Jul 5, 2024 •

edited

Loading

coveralls commented Jul 5, 2024 •

edited

Loading

typed-sigterm commented Jul 5, 2024

feat: add @vuepress/bundler-farm #1583

Are you sure you want to change the base?

feat: add @vuepress/bundler-farm #1583

Conversation

typed-sigterm commented Jul 1, 2024 • edited Loading

🚧 Experimental + Work in Progress 🚧

Before submitting the PR, please make sure you do the following

What is the purpose of this pull request?

Description

coveralls commented Jul 1, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9739675060

Details

💛 - Coveralls

coveralls commented Jul 1, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9739790629

Details

💛 - Coveralls

Mister-Hope commented Jul 1, 2024

coveralls commented Jul 1, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9740770751

Details

💛 - Coveralls

coveralls commented Jul 1, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9741133313

Details

💛 - Coveralls

coveralls commented Jul 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9756258638

Details

💛 - Coveralls

coveralls commented Jul 2, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9756442612

Details

💛 - Coveralls

meteorlxy left a comment

Choose a reason for hiding this comment

meteorlxy Jul 2, 2024

Choose a reason for hiding this comment

typed-sigterm Jul 5, 2024

Choose a reason for hiding this comment

coveralls commented Jul 5, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9801782315

Details

💛 - Coveralls

coveralls commented Jul 5, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9801773016

Details

💛 - Coveralls

coveralls commented Jul 5, 2024 • edited Loading

Pull Request Test Coverage Report for Build 9801846027

Details

💛 - Coveralls

typed-sigterm commented Jul 5, 2024

feat: add `@vuepress/bundler-farm` #1583

feat: add `@vuepress/bundler-farm` #1583

typed-sigterm commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 1, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 2, 2024 •

edited

Loading

coveralls commented Jul 5, 2024 •

edited

Loading

coveralls commented Jul 5, 2024 •

edited

Loading

coveralls commented Jul 5, 2024 •

edited

Loading