feat(runtime-vapor): onMounted and onUnMounted hook #43
Conversation
| get isMounted(): boolean | ||
| get isUnMounted(): boolean | ||
| isMountedRef: Ref<boolean> | ||
| isUnMountedRef: Ref<boolean> |
There was a problem hiding this comment.
I don't quite understand the handling of this flag. @sxzz
At the very least, if implementing 'isUnmounted', it would probably be good to rewrite it as true during unmount.
ref: #42
Flags related to lifecycle
I had implemented it so that isMounted is set to false when unmounting,
In traditional components, it seems that isUnmounted is set to true.
Which approach should we follow for the implementation? (In this PR, I have added the isUnmounted flag.)
There was a problem hiding this comment.
The default value of 'isUnmounted' in 'runtime-core' is false, so I have set it to false.
There was a problem hiding this comment.
Yes, that seems to be the correct default value,
but I do think it should be marked as true when the Component is unmounted.
https://github.com/vuejs/core-vapor/pull/43/files#diff-e05b05171d6196eb88c0845a17e0482ab342a992e8e388da3dca363fadeafc08R67-R80
(However, currently when unmounting, the implementation sets isMounted to false, so I'm not quite clear on how these two flags should be treated...)
There was a problem hiding this comment.
Oops, I forgot. My bad. 😢
There was a problem hiding this comment.
Oh no, please don't feel bad. 😸
In any case, since I don't have a clear grasp of how these two flags should be treated, I'd like to leave the rest to @sxzz ...
Co-authored-by: 三咲智子 Kevin Deng <[email protected]>
^^ source code
vvv result