Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow choosing vue version on creation (and in presets) #5637

Merged
merged 65 commits into from
Jul 24, 2020

Conversation

haoqunjiang
Copy link
Member

@haoqunjiang haoqunjiang commented Jul 1, 2020

This PR:

  • adds a vueVersion field in the preset schema (accepts a string, defaults to '2', and can be '3').
  • adds a new "Default (Vue 3 Preview)" preset
  • allow choosing Vue version on vue create manual mode

Progress:

Manually tested (should write unit tests later):

  • vue invoke in a Vue 3 project
  • JSX & TSX

Maybe later:

  • Wrap object exports with defineComponent calls in .vue files

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

@haoqunjiang
Copy link
Member Author

So, I've got most Vue 3 related features working now.
I'd like to hear more about your opinions on this PR's approach. Any review comments would be appreciated 🙂

@haoqunjiang
Copy link
Member Author

All existing tests passed! A few more test cases and we'll be good to go 😁

@haoqunjiang haoqunjiang merged commit b1772ca into dev Jul 24, 2020
@haoqunjiang haoqunjiang deleted the feat-vue3-option branch July 24, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants