Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate ComponentCustomOptions through ComponentCustomBase (fix #2332) #2333

Conversation

ghost
Copy link

@ghost ghost commented Aug 6, 2024

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit b921f0e
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/66d24fa7ff1e5e0008bee05e

@posva posva added the needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified label Aug 6, 2024
kingyue737 added a commit to kingyue737/vitify-nuxt that referenced this pull request Aug 14, 2024
@Brads3290
Copy link

I noticed the same across several of my Nuxt apps after updating dependencies. Pinning to 4.4.0 fixed the issue.

@skywalker512
Copy link

skywalker512 commented Aug 15, 2024

In my experience, if the dependencies in the project are written as declare module 'vue' or declare module '@vue/runtime-core' (Both ways of writing appear in your dependence.),

Only one of these two ways will work, and '@vue/runtime-core' always win (I'm not familiar with Typescript)

You can check whether your dependency has such a situation. When I completely replace it with declare module 'vue', the problem disappears. Then we can see that pinia also makes a similar replacement.

vuejs/pinia@8a6ce86

More information youzan/vant#13067

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a reproduction of the issue at #2341.

@ghost ghost force-pushed the fix-restore-component-custom-options-and-properties branch 2 times, most recently from 50c0bbb to 3664fb1 Compare August 30, 2024 23:01
@ghost ghost force-pushed the fix-restore-component-custom-options-and-properties branch from 3664fb1 to b921f0e Compare August 30, 2024 23:03
@ghost
Copy link
Author

ghost commented Aug 30, 2024

@danielroe @posva I believe I've figured out what was missing when augmenting the vue module. What do you think?

@ghost ghost changed the title revert ComponentCustomOptions and ComponentCustomProperties extensions (fix #2332) propagate ComponentCustomOptions through ComponentCustomBase (fix #2332) Aug 30, 2024
Repository owner closed this by deleting the head repository Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reproduction This bug hasn't provided a valid reproduction for the bug to be verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants