-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: support dir in meta for pages #2085
Conversation
✅ Deploy Preview for vue-router ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Shouldn't this be set directly in Vitepress theme 🤔 |
Yea, I think it's a good idea. Another PR has been created there. :-) |
17e8e7f
to
306ca21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
=======================================
Coverage 90.85% 90.85%
=======================================
Files 24 24
Lines 1115 1115
Branches 347 347
=======================================
Hits 1013 1013
Misses 63 63
Partials 39 39 ☔ View full report in Codecov by Sentry. |
@posva I reset this branch and just bumped the vitepress version. It works as expected from my side. Please take a look. 🙏 |
* docs: style error caused by banner (vuejs#2099) * docs: support dir in meta for pages (vuejs#2085)
Support adding dir in meta like:
The demo screenshot
So we can control the direction per each page.
Thanks.
/cc @brc-dd