Skip to content

feat: add support for viewing sourcemap #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented May 16, 2025

No description provided.

Copy link

vercel bot commented May 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2025 2:51am

Copy link

pkg-pr-new bot commented May 16, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@vue/repl@341

commit: d8d6097

@edison1105 edison1105 requested a review from wangcch May 16, 2025 09:40
@edison1105 edison1105 marked this pull request as ready for review May 26, 2025 13:54
Copy link
Collaborator

@wangcch wangcch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~

for (let i = 0; i < len; i++) binary += String.fromCharCode(combinedArray[i])

// Convert the binary string to a base64 string and return it
return `https://evanw.github.io/source-map-visualization#${btoa(binary)}`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we consider opening the domain and controlling the display configuration of open sourcemap button?🤔

Copy link
Member Author

@edison1105 edison1105 Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users probably won't need this feature. it's mainly for conveniently debugging source map issues, I think we should add a prop to hide the open sourcemap button by default, I'll add it later.

updated via d8d6097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants