fix: don't camelize attributes for plain elements #3750
Merged
+21
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plain (native) elements should not have their props camelized as then the attribute names won't match the type definition if the element has those. For example
path
element defines type for thestroke-width
attribute but since Volar "camelizes" the attribute name by default, it triggers type error due tostrokeWidth
not matching thestroke-width
key.I suppose the
ElementTypes.ELEMENT
type does not necessarily mean "native element" but hopefully it's close enough and correct to not camelize attributes by default for those elements.