Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Improved performance and reduced memory consumption #90

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

negezor
Copy link

@negezor negezor commented Jun 2, 2024

Hi. Applying all the same optimizations as here vueform/multiselect#411. In this world, a little optimization never hurt anyone 😅

In addition to the previous PR, the watchers are grouped here to reduce the number of effectScope created. And since we don't need to make all nouislider properties reactive, it's better to leave this job to shallowRef().

@tomsdob
Copy link

tomsdob commented Jul 2, 2024

These changes would be greatly appreciated as the destroy() function in src/composables/useSlider.js calls slider$.value.off() but slider$.value is sometimes non existent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants