Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add keyboardPrediction prop #7664

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thinhbuzz
Copy link

@thinhbuzz thinhbuzz commented Jun 17, 2024

add keyboardPrediction prop to restored previous behavior when users search, similar to earlier versions.

This PR will add the option to support features related to composition events without breaking the old behavior.
The new change in version 4.2.* prevented the current behavior of inputs from being completely broken, causing nearly all of our apps to break upon upgrade.

2024-06-17.14-12-06.mp4

@thinhbuzz thinhbuzz marked this pull request as draft June 17, 2024 07:18
@thinhbuzz
Copy link
Author

thinhbuzz commented Jun 17, 2024

@tangjinzhou Please help me take a look at this. I will add the missing documents in a few hours.
If you have any better ideas, then please implement them and ignore this PR.

@thinhbuzz thinhbuzz marked this pull request as ready for review June 17, 2024 11:14
@thinhbuzz thinhbuzz force-pushed the feature/keyboard-prediction branch from 6e4db8e to 2e76570 Compare June 17, 2024 11:26
@thinhbuzz
Copy link
Author

@tangjinzhou Please help me take a look at this. I will add the missing documents in a few hours. If you have any better ideas, then please implement them and ignore this PR.
This PR to handle commit
752686e

Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 17, 2024
@thinhbuzz
Copy link
Author

@tangjinzhou can you take a look at it?

@github-actions github-actions bot removed the Stale label Aug 18, 2024
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Oct 17, 2024
@thinhbuzz
Copy link
Author

@tangjinzhou Can you take the time to look over this PR?

@github-actions github-actions bot removed the Stale label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant