Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive when the clicked element is removed #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NiciusB
Copy link

@NiciusB NiciusB commented Oct 26, 2020

When the click deletes the clicked element, the callback fires, even if the clicked element was the main element's children.

This can be fixed by checking the click event path for the main element, like they do in https://github.com/ndelvalle/v-click-outside/blob/master/src/v-click-outside.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant