-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add All4One #382
Add All4One #382
Conversation
…tional enconding utils added
hey @ImaGonEs thanks for contributing. We are just missing some things that need to be added before merging. Can you add the tests and documentation? You can copy-paste them from the available methods and change them accordingly. Another thing, I noticed that the config file for imagenet-100 is missing. |
Hi! Tests and documentation added (I adapted the ones you created for NNCLR/NNBYOL). ImageNet100 config file is now available also. Tell me if anything is missing :) |
@ImaGonEs thanks for that. I took a quick look, but I'll read it more carefully later. One thing is to move the documentation of the positional_encodings to |
Sure. I moved it to utils.rst and added the temperature parameter to the test (I missed it on the last commit). |
Codecov ReportAttention:
Additional details and impacted files
*This pull request uses carry forward flags. Click here to find out more.
|
@ImaGonEs I've fixed some minor stuff on the code that was out of standard. I'll merge the code, if there's anything else, let me know. |
Thank you for the effort! I did the code using an older version, sorry for the inconvenience. |
@ImaGonEs I'll add it :) |
…tional enconding utils added. README file adapted to include All4One.