Remove sampling decision from runtime #541
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Node runtime is overriding jaeger-agent sampling decision. It is also creating dangling RootSpans anytime a current application doesn't receive a RootSpan from the parent request, e.g: Kuberouter.
This PR removes sampler configs enabling the default behavior, which is:
It also only creates tracing spans when a RootSpan comes from the Router.
What problem is this solving?
How should this be manually tested?
Screenshots or example usage
Types of changes