Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sampling decision from runtime #541

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Conversation

Jeymisson
Copy link
Contributor

@Jeymisson Jeymisson commented Aug 30, 2023

What is the purpose of this pull request?

Node runtime is overriding jaeger-agent sampling decision. It is also creating dangling RootSpans anytime a current application doesn't receive a RootSpan from the parent request, e.g: Kuberouter.

This PR removes sampler configs enabling the default behavior, which is:

Remote (sampler.type=remote, which is also the default) sampler consults jaeger-agent for the appropriate sampling strategy to use in the current service. This allows controlling the sampling strategies in the services from a central configuration in Jaeger backend (see Remote Sampling), or even dynamically (see Adaptive Sampling).

It also only creates tracing spans when a RootSpan comes from the Router.

Screenshot 2023-08-30 at 15 21 32

What problem is this solving?

How should this be manually tested?

Screenshots or example usage

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@Jeymisson Jeymisson merged commit 750d149 into master Aug 30, 2023
3 checks passed
@Jeymisson Jeymisson deleted the chore/tracing-sampling branch August 30, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants