Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prometheusLoggerMiddleware async typing #536

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Remove prometheusLoggerMiddleware async typing #536

merged 2 commits into from
Jul 7, 2023

Conversation

arturpimentel
Copy link
Contributor

@arturpimentel arturpimentel commented Jul 7, 2023 •
edited
Loading

Last PR had a build problem because of a misplaced async directive. Removing that solves the issue

To test:
Run yarn build. It should execute without errors

@arturpimentel arturpimentel self-assigned this Jul 7, 2023
@arturpimentel arturpimentel requested review from eduardocesb and removed request for Jeymisson and filafb July 7, 2023 20:39
eduardocesb
eduardocesb approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@eduardocesb eduardocesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@arturpimentel arturpimentel merged commit d7acc18 into master Jul 7, 2023
2 checks passed
@arturpimentel arturpimentel deleted the fix/v6.45.18/build branch July 7, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardocesb eduardocesb eduardocesb approved these changes

@Jeymisson Jeymisson Awaiting requested review from Jeymisson

@filafb filafb Awaiting requested review from filafb

Assignees

@arturpimentel arturpimentel

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturpimentel @eduardocesb