Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/prometheus metrics #535

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Fix/prometheus metrics #535

merged 2 commits into from
Jul 7, 2023

Conversation

filafb
Copy link
Contributor

@filafb filafb commented Jul 7, 2023

What is the purpose of this pull request?

The metrics to prometheus has been down since the update of prom-client.

Investigating the differences between v12 and v14, the metrics from registry are now a promise, and before it was a string.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@filafb filafb self-assigned this Jul 7, 2023
@arturpimentel arturpimentel merged commit c8b4ca4 into master Jul 7, 2023
@arturpimentel arturpimentel deleted the fix/prometheus-metrics branch July 7, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arturpimentel arturpimentel arturpimentel approved these changes

@Jeymisson Jeymisson Awaiting requested review from Jeymisson

@eduardocesb eduardocesb Awaiting requested review from eduardocesb

Assignees

@filafb filafb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filafb @arturpimentel