XTNSNS-391 Bump graphql-upload to v13.0.0 #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairatma
changed the title
arturpimentel
approved these changes
Jul 7, 2023
filafb
reviewed
Jul 7, 2023
Yes, it is! 🙏 |
I've just triple checked to be sure and it's confirmed: this version works correctly in both node 12 and node 16. Regardless of that it would be great to test this within IO's environment when we publish a version of this package to NPM, before applying to service-runtime-node. My tests so far were all 100% localhost. Can I merge this and publish a new patch version now to test? Once I confirm it's working I'll let you guys know so we can move forward with the service-runtime-node change as well. |
mairatma
force-pushed
the
graphqlUploadBump
branch
from
d9e9841
to
fba14d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Upgrade the version of graphql-upload.
What problem is this solving?
We're using a very outdated version of graphql-upload (v8) which isn't compatible with node 16. This causes graphql apps such as pages-graphql to fail for any mutation that uses uploads.
Version v13 works correctly in node 16, unlocking us to upgrade node on pages-graphql and other graphql apps that use upload features.
How should this be manually tested?
I managed to manually test by running pages-graphql locally on no 16, with this version of @vtex/api linked to it.
For a final test within IO's environment we need to publish a new version of @vtex/api so that we can use it to test a link of pages-graphql using the 7.x node builder. Once we have the published version I'll do that final test.
Screenshots or example usage
Before
After
Types of changes