Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/bump prom client #531

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Chore/bump prom client #531

merged 3 commits into from
Jul 3, 2023

Conversation

filafb
Copy link
Contributor

@filafb filafb commented Jul 3, 2023

What is the purpose of this pull request?

This version bumps the prom-client version to remove a deprecation warning in the CLI when linking a project to the node builder using node 16.

What problem is this solving?

It removes the following deprecation warning from CLI when linking an application.
Screenshot 2023-07-03 at 4 12 48 PM

How should this be manually tested?

  • Create a new workspace in vtexgame1 account;
  • Run yarn link in the node-vtex-api;
  • Open a project using the node builder and update the version to 7.x;
  • In the same project, cd to /node and run yarn link @vtex/api;
  • Link the project to the workspace. You should not see the warning above.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Bumping prom-client version to remove a warning in the CLI when updating to node 16
@filafb filafb self-assigned this Jul 3, 2023
Copy link
Contributor

@eduardocesb eduardocesb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@filafb filafb merged commit 65b1396 into master Jul 3, 2023
2 checks passed
@filafb filafb deleted the chore/bump-prom-client branch July 3, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants