Simplifies logic of LRUDiskCache #527
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipewl
reviewed
Jun 7, 2023
| @@ -59,18 +57,10 @@ export class LRUDiskCache<V> implements CacheLayer<string, V>{ | |||
| public get = async (key: string): Promise<V | void> => { | |||
| const timeOfDeath = this.lruStorage.get(key) | |||
There was a problem hiding this comment.
Confused when I read this. The items stored in the cache are timestamps?
🤔
There was a problem hiding this comment.
Yes! It took me a while to understand it, too. I'm still unsure if we should keep this behavior, but I don't want to change many things simultaneously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
This PR changes the LRUDiskCache implementations to use the dispose function of the LRU implementation to clear the disk cache instead of implementing it on get and set functions.
What problem is this solving?
After adding some LRUDiskCache to our code, we saw that its metrics were not working correctly. By checking the implementation, I suspect that when any key needs to be removed from the cache, none of the keys will be retrieved due to this logic. The key to be deleted is not being verified before removal.
How should this be manually tested?
I think the only way to test this properly is installing it in some accounts and check the behavior.
Types of changes