add error handling to async case

vtex · Jun 3, 2024 · a2569ec · a2569ec
1 parent e3494eb
commit a2569ec
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/HttpClient/middlewares/cache.ts b/src/HttpClient/middlewares/cache.ts
@@ -224,16 +224,19 @@ export const cacheMiddleware = ({ type, storage, asyncSet }: CacheOptions) => {
 
       const cacheWriteSpan = createCacheSpan(cacheType, 'write', tracer, span)
       try {
-        const storageSet = () =>
-          storage.set(setKey, {
+        const storageSet = async () =>
+          await storage.set(setKey, {
             etag,
             expiration,
             response: {data: cacheableData, headers, status},
             responseEncoding,
             responseType,
           })
         if (asyncSet) {
-          storageSet()
+          storageSet().catch(error => {
+            ErrorReport.create({ originalError: error }).injectOnSpan(cacheWriteSpan);
+            logger?.warn({ message: 'Error writing to the HttpClient cache asynchronously', error });
+          })
         } else {
           await storageSet()
           span?.log({