Remove sampling decision from runtime & only create tracing spans whe…

…n they come from router
vtex · Aug 30, 2023 · 928ceb1 · 928ceb1
1 parent 1b3c549
commit 928ceb1
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/service/tracing/TracerSingleton.ts b/src/service/tracing/TracerSingleton.ts
@@ -33,12 +33,6 @@ export class TracerSingleton {
       reporter: {
         agentHost: process.env.VTEX_OWN_NODE_IP,
       },
-      sampler: {
-        host: process.env.VTEX_OWN_NODE_IP,
-        param: 0.05,
-        refreshIntervalMs: 60 * 1000,
-        type: 'remote',
-      },
       serviceName,
     }
 

diff --git a/src/service/tracing/tracingMiddlewares.ts b/src/service/tracing/tracingMiddlewares.ts
@@ -30,14 +30,14 @@ export const addTracingMiddleware = (tracer: Tracer) => {
   return async function addTracing(ctx: ServiceContext, next: () => Promise<void>) {
     const start = process.hrtime()
     concurrentRequests.inc(1)
+    const rootSpan = tracer.extract(FORMAT_HTTP_HEADERS, ctx.request.headers) as undefined | SpanContext
 
-    if (PATHS_BLACKLISTED_FOR_TRACING.includes(ctx.request.path)) {
+    if (!shouldTrace(ctx, rootSpan)) {
       await next()
       concurrentRequests.dec(1)
       return
     }
 
-    const rootSpan = tracer.extract(FORMAT_HTTP_HEADERS, ctx.request.headers) as undefined | SpanContext
     const currentSpan = tracer.startSpan('unknown-operation', {
       childOf: rootSpan,
       tags: { [OpentracingTags.SPAN_KIND]: OpentracingTags.SPAN_KIND_RPC_SERVER },
@@ -150,3 +150,8 @@ export const traceUserLandRemainingPipelineMiddleware = () => {
     }
   }
 }
+function shouldTrace(ctx: ServiceContext, rootSpan: SpanContext | undefined) {
+  // Should trace if path isnt blacklisted and tracing decision came from the edge
+  return !PATHS_BLACKLISTED_FOR_TRACING.includes(ctx.request.path) && rootSpan
+}
+