Merge pull request #532 from vtex/fix/enable-disk-cache

fix: add cacheableType for httpclient
vtex · Jul 6, 2023 · 861a294 · 861a294
2 parents 65b1396 + 22c5a57
commit 861a294
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/src/HttpClient/HttpClient.ts b/src/HttpClient/HttpClient.ts
@@ -38,6 +38,8 @@ export class HttpClient {
   public name: string
 
   private logger: Logger
+  private cacheableType: CacheType
+
   private runMiddlewares: compose.ComposedMiddleware<MiddlewareContext>
 
   public constructor(opts: ClientOptions) {
@@ -72,9 +74,11 @@ export class HttpClient {
       httpsAgent,
       tracer,
       logger,
+      cacheableType = CacheType.Memory,
     } = opts
     this.name = name || baseURL || 'unknown'
     this.logger = logger
+    this.cacheableType = cacheableType
 
     const limit = concurrency && concurrency > 0 && pLimit(concurrency) || undefined
     const headers: Record<string, string> = {
@@ -205,7 +209,7 @@ export class HttpClient {
   }
 
   private getConfig = (url: string, config: RequestConfig = {}): CacheableRequestConfig => ({
-    cacheable: CacheType.Memory,
+    cacheable: this.cacheableType,
     memoizable: true,
     ...config,
     url,

diff --git a/src/HttpClient/typings.ts b/src/HttpClient/typings.ts
@@ -115,6 +115,7 @@ export interface InstanceOptions {
   name?: string
   serverTimings?: Record<string, string>
   httpsAgent?: AxiosRequestConfig['httpsAgent']
+  cacheableType?: CacheType
 }
 
 export interface IOResponse<T> {