Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: new RenderSections for all pages #2558

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
de78a9a
feat: split the global sections in own file
eduardoformiga Nov 12, 2024
a2e671f
feat: split the homepage (index) sections in own file
eduardoformiga Nov 12, 2024
47d709b
feat: new RenderSection structure
eduardoformiga Nov 12, 2024
3ce6ff7
feat: adapts homepage to use new RenderSection
eduardoformiga Nov 12, 2024
dfdb51b
feat: adapts login to use new RenderSection
eduardoformiga Nov 12, 2024
25e043c
feat: adapts 404 page to use new RenderSection
eduardoformiga Nov 12, 2024
ba59b93
feat: adapts 500 page to use new RenderSection
eduardoformiga Nov 12, 2024
7ef5fed
feat: improves PLP to use Promise.all
eduardoformiga Nov 12, 2024
e0153ff
feat: split plp components into its own file
eduardoformiga Nov 12, 2024
48b043f
feat: adapts landing page to use new RenderSection
eduardoformiga Nov 12, 2024
4aba1cb
feat: adapts PLP to use new RenderSection
eduardoformiga Nov 12, 2024
fc5754d
feat: adapts PLP and landing page (template) to use new RenderSection
eduardoformiga Nov 12, 2024
2f68f58
feat: adds optional section prop in RenderSection
eduardoformiga Nov 12, 2024
d65bf6c
feat: adapts account page to use new RenderSection
eduardoformiga Nov 12, 2024
891a4c4
feat: adapts checkout (redirect) page to use new RenderSection
eduardoformiga Nov 12, 2024
e24fcf4
feat: adapts PDP to use new RenderSection
eduardoformiga Nov 12, 2024
880378a
feat: split search section components into its own file
eduardoformiga Nov 12, 2024
34a4283
feat: adapts Search Page to use new RenderSection
eduardoformiga Nov 12, 2024
d122d10
feat: removes GlobalSections component
eduardoformiga Nov 12, 2024
7513476
fix: LazyLoadingSection component
eduardoformiga Nov 12, 2024
4957387
feat: adds global sections to Landing Page
eduardoformiga Nov 12, 2024
df41a0c
Merge branch 'main' into feat/SFS-1512-and-SFS-1513-performance-new-R…
eduardoformiga Nov 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions packages/core/src/components/cms/GlobalSections.tsx
Original file line number Diff line number Diff line change
@@ -1,50 +1,13 @@
import { Locator, Section } from '@vtex/client-cms'
import storeConfig from 'discovery.config'
import type { ComponentType } from 'react'
import { PropsWithChildren } from 'react'
import CUSTOM_COMPONENTS from 'src/customizations/src/components'
import { PageContentType, getPage } from 'src/server/cms'

import RenderSections from './RenderSections'

import { OverriddenDefaultAlert as Alert } from 'src/components/sections/Alert/OverriddenDefaultAlert'
import Footer from 'src/components/sections/Footer'
import { OverriddenDefaultNavbar as Navbar } from 'src/components/sections/Navbar/OverriddenDefaultNavbar'
import { OverriddenDefaultRegionBar as RegionBar } from 'src/components/sections/RegionBar/OverriddenDefaultRegionBar'

import CartSidebar from 'src/components/cart/CartSidebar'
import RegionModal from 'src/components/region/RegionModal'

export const GLOBAL_SECTIONS_CONTENT_TYPE = 'globalSections'

export type GlobalSectionsData = {
sections: Section[]
}

/* A list of components that can be used in the CMS. */
const COMPONENTS: Record<string, ComponentType<any>> = {
Alert,
Navbar,
RegionBar,
RegionModal,
CartSidebar,
Footer,
...CUSTOM_COMPONENTS,
}

function GlobalSections({
children,
...otherProps
}: PropsWithChildren<GlobalSectionsData>) {
return (
<RenderSections components={COMPONENTS} {...otherProps}>
<main>{children}</main>
</RenderSections>
)
}

export default GlobalSections

export const getGlobalSectionsData = async (
previewData: Locator
): Promise<GlobalSectionsData> => {
Expand Down
42 changes: 25 additions & 17 deletions packages/core/src/components/cms/RenderSections.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,14 @@ import { Section } from '@vtex/client-cms'
import dynamic from 'next/dynamic'
import SectionBoundary from './SectionBoundary'
import ViewportObserver from './ViewportObserver'
import COMPONENTS from './global/Components'

import { useUI } from '@faststore/ui'

interface Props {
components: Record<string, ComponentType<any>>
sections: Array<{ name: string; data: any }>
components?: Record<string, ComponentType<any>>
globalSections?: Array<{ name: string; data: any }>
sections?: Array<{ name: string; data: any }>
}

const SECTIONS_OUT_OF_VIEWPORT = ['CartSidebar', 'RegionModal']
Expand Down Expand Up @@ -45,7 +47,6 @@ const useDividedSections = (sections: Section[]) => {
* 2. Checking the UI context for Sections that are not in the viewport, such as the CartSidebar and RegionModal.
*
* @param sectionName
* @returns
*/
export const LazyLoadingSection = ({
sectionName,
Expand All @@ -60,11 +61,8 @@ export const LazyLoadingSection = ({
const shouldLoad =
(sectionName === 'CartSidebar' && displayCart) ||
(sectionName === 'RegionModal' && displayModal)
if (!shouldLoad) {
return null
}

return children
return shouldLoad ? <>{children}</> : null
}
return (
<ViewportObserver sectionName={sectionName}>{children}</ViewportObserver>
Expand All @@ -74,7 +72,7 @@ export const LazyLoadingSection = ({
const RenderSectionsBase = ({ sections = [], components }: Props) => {
return (
<>
{sections.map(({ name, data }, index) => {
{sections.map(({ name, data = {} }, index) => {
const Component = components[name]

if (!Component) {
Expand All @@ -88,7 +86,9 @@ const RenderSectionsBase = ({ sections = [], components }: Props) => {

return (
<SectionBoundary key={`cms-section-${name}-${index}`} name={name}>
<Component {...data} />
<LazyLoadingSection sectionName={name}>
<Component {...data} />
</LazyLoadingSection>
</SectionBoundary>
)
})}
Expand All @@ -98,21 +98,29 @@ const RenderSectionsBase = ({ sections = [], components }: Props) => {

function RenderSections({
children,
globalSections,
sections,
...otherProps
components = COMPONENTS,
}: PropsWithChildren<Props>) {
const { hasChildren, firstSections, lastSections } =
useDividedSections(sections)
const { firstSections, lastSections } = useDividedSections(
globalSections ?? sections
)

return (
<>
<RenderSectionsBase sections={firstSections} {...otherProps} />

<Toast />
{firstSections && (
<RenderSectionsBase sections={firstSections} components={components} />
)}
{sections && sections.length > 0 && (
<RenderSectionsBase sections={sections} components={components} />
)}
{children}
<LazyLoadingSection sectionName="Toast">
<Toast />
</LazyLoadingSection>

{hasChildren && (
<RenderSectionsBase sections={lastSections} {...otherProps} />
{lastSections && (
<RenderSectionsBase sections={lastSections} components={components} />
)}
</>
)
Expand Down
55 changes: 55 additions & 0 deletions packages/core/src/components/cms/plp/Components.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import dynamic from 'next/dynamic'
import { ComponentType } from 'react'

import { OverriddenDefaultBreadcrumb as Breadcrumb } from 'src/components/sections/Breadcrumb/OverriddenDefaultBreadcrumb'
import { OverriddenDefaultHero as Hero } from 'src/components/sections/Hero/OverriddenDefaultHero'
import { OverriddenDefaultProductGallery as ProductGallery } from 'src/components/sections/ProductGallery/OverriddenDefaultProductGallery'
import CUSTOM_COMPONENTS from 'src/customizations/src/components'
import { default as GLOBAL_COMPONENTS } from '../global/Components'

const BannerText = dynamic(
() =>
import(
/* webpackChunkName: "BannerText" */
'src/components/sections/BannerText/OverriddenDefaultBannerText'
).then((mod) => ({ default: mod.OverriddenDefaultBannerText })),
{ ssr: false }
)
const Newsletter = dynamic(
() =>
import(
/* webpackChunkName: "Newsletter" */
'src/components/sections/Newsletter/OverriddenDefaultNewsletter'
).then((mod) => ({ default: mod.OverriddenDefaultNewsletter })),
{ ssr: false }
)
const ProductShelf = dynamic(
() =>
import(
/* webpackChunkName: "ProductShelf" */
'src/components/sections/ProductShelf/OverriddenDefaultProductShelf'
).then((mod) => ({ default: mod.OverriddenDefaultProductShelf })),
{ ssr: false }
)
const ProductTiles = dynamic(
() =>
import(
/* webpackChunkName: "ProductTiles" */
'src/components/sections/ProductTiles'
),
{ ssr: false }
)

const COMPONENTS: Record<string, ComponentType<any>> = {
...GLOBAL_COMPONENTS,
Breadcrumb,
Hero,
ProductGallery,
BannerText,
Newsletter,
ProductShelf,
ProductTiles,
...CUSTOM_COMPONENTS,
}

export default COMPONENTS
64 changes: 64 additions & 0 deletions packages/core/src/components/cms/search/Components.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
import dynamic from 'next/dynamic'
import { ComponentType } from 'react'

import { OverriddenDefaultBreadcrumb as Breadcrumb } from 'src/components/sections/Breadcrumb/OverriddenDefaultBreadcrumb'
import { OverriddenDefaultHero as Hero } from 'src/components/sections/Hero/OverriddenDefaultHero'
import { OverriddenDefaultProductGallery as ProductGallery } from 'src/components/sections/ProductGallery/OverriddenDefaultProductGallery'
import CUSTOM_COMPONENTS from 'src/customizations/src/components'
import { default as GLOBAL_COMPONENTS } from '../global/Components'

const BannerText = dynamic(
() =>
import(
/* webpackChunkName: "BannerText" */
'src/components/sections/BannerText/OverriddenDefaultBannerText'
).then((mod) => ({ default: mod.OverriddenDefaultBannerText })),
{ ssr: false }
)
const BannerNewsletter = dynamic(
() =>
import(
/* webpackChunkName: "BannerNewsletter" */
'src/components/sections/BannerNewsletter/BannerNewsletter'
),
{ ssr: false }
)
const Newsletter = dynamic(
() =>
import(
/* webpackChunkName: "Newsletter" */
'src/components/sections/Newsletter/OverriddenDefaultNewsletter'
).then((mod) => ({ default: mod.OverriddenDefaultNewsletter })),
{ ssr: false }
)
const ProductShelf = dynamic(
() =>
import(
/* webpackChunkName: "ProductShelf" */
'src/components/sections/ProductShelf/OverriddenDefaultProductShelf'
).then((mod) => ({ default: mod.OverriddenDefaultProductShelf })),
{ ssr: false }
)
const ProductTiles = dynamic(
() =>
import(
/* webpackChunkName: "ProductTiles" */
'src/components/sections/ProductTiles'
),
{ ssr: false }
)

const COMPONENTS: Record<string, ComponentType<any>> = {
...GLOBAL_COMPONENTS,
Breadcrumb,
Hero,
ProductGallery,
BannerText,
BannerNewsletter,
Newsletter,
ProductShelf,
ProductTiles,
...CUSTOM_COMPONENTS,
}

export default COMPONENTS
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { OverriddenDefaultNewsletter as Newsletter } from 'src/components/sectio
import { OverriddenDefaultProductShelf as ProductShelf } from 'src/components/sections/ProductShelf/OverriddenDefaultProductShelf'
import ProductTiles from 'src/components/sections/ProductTiles'
import CUSTOM_COMPONENTS from 'src/customizations/src/components'
import { default as GLOBAL_COMPONENTS } from 'src/components/cms/global/Components'
import MissingContentError from 'src/sdk/error/MissingContentError/MissingContentError'
import PageProvider from 'src/sdk/overrides/PageProvider'
import type { PageContentType } from 'src/server/cms'
Expand All @@ -21,6 +22,7 @@ import storeConfig from 'discovery.config'

/* A list of components that can be used in the CMS. */
const COMPONENTS: Record<string, ComponentType<any>> = {
...GLOBAL_COMPONENTS,
Hero,
BannerText,
BannerNewsletter,
Expand All @@ -36,12 +38,14 @@ export type LandingPageProps = {
page: PageContentType
slug?: string
serverData?: unknown
globalSections?: Array<{ name: string; data: any }>
}

export default function LandingPage({
page: { sections, settings },
slug,
serverData,
globalSections,
}: LandingPageProps) {
const context = {
data: serverData,
Expand Down Expand Up @@ -87,7 +91,11 @@ export default function LandingPage({
(not the HTML tag) before rendering it here.
*/}
<PageProvider context={context}>
<RenderSections sections={sections} components={COMPONENTS} />
<RenderSections
sections={sections}
globalSections={globalSections}
components={COMPONENTS}
/>
</PageProvider>
</>
)
Expand Down
Loading
Loading