-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search product control implementations #2547
Open
ramondorosario-ct
wants to merge
15
commits into
vtex:main
Choose a base branch
from
cubos-vtex:feat/search-product-control-implementations
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: search product control implementations #2547
ramondorosario-ct
wants to merge
15
commits into
vtex:main
from
cubos-vtex:feat/search-product-control-implementations
+291
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tex/faststore into feat/search-product-item-control
ramondorosario-ct
added
enhancement
New feature or request
depends on
Depends on another PR - Please mention the PR
labels
Nov 6, 2024
ramondorosario-ct
requested review from
lucasfp13 and
lariciamota
and removed request for
a team
November 6, 2024 20:14
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ramondorosario-ct
changed the title
feaT: search product control implementations
feat: search product control implementations
Nov 6, 2024
packages/core/src/components/search/SearchProductItem/SearchProductItem.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is about the implementation of the
Quick Order
feature. Two other PRs were created, one related to the new SearchProductItemControl component and another handling all the typing.In this PR, the new component, typing, and some logic related to the overall implementation of the feature are brought together. A small adjustment was also made to the useBuyButton hook to prevent the
SliderOver
from opening when an item is added to the cart.Attention This PR has dependencies on PRs: #2543 and #2546.
ps: Once PR #2543 is merged, the number of changes in this PR will decrease.
Printscreens
ps: the "Select multiple" button is just a regular button used for visualization purposes. Once the SKUMatrix is passed, the SKUMatrix trigger will be displayed.