-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add params sponsoredCount query search #2519
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
@sanderpaniago. The CI is failing. I think you need to update the unit tests. |
@pedromtec resolvido o erro no CI |
How will our customers set the |
It will be a parameter passed in the search query |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. I have a question (non-blocking) . At what point does this parameter go to the query string? Will this be done in another PR?
What's the purpose of this pull request?
Implement the sponsoredCount parameter in the search query, making it possible to control the number of sponsored products returned.
How it works?
A new non-mandatory parameter has been added to the search querry called sponsoredCount, which you just need to set when calling the querry:
How to test it?
Starters Deploy Preview
References
Checklist
You may erase this after checking them all 😉
PR Title and Commit Messages
feat
,fix
,chore
,docs
,style
,refactor
andtest
PR Description
breaking change
,bug
,contributing
,performance
,documentation
..Dependencies
yarn.lock
file when there were changes to the packages