feat: start middleware #2517
Draft
feat: start middleware #2517
+1,026
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
pedromtec
added a commit
that referenced
this pull request
Nov 12, 2024
## What's the purpose of this pull request? This task will allow enabling the redirects middleware within **@faststore/core** during the build process based on a flag. The idea is to enable this functionality only for projects that have the flag `ENABLE_REDIRECTS_MIDDLEWARE` saved in the env vars and which are hosted by homebrew. In the future, we intend to have control of this feature through webops. Next steps: - Set this flag in a pipeline env var. - Implements dynamoDB client (Reference: #2517) ## How it works? The key is the name of the file: **middleware__DISABLED.ts** This middleware is disabled by default. Only stores that are in **homebrew** and want this functionality will be able to enable it via a feature flag. When the flag is active, the CLI at build time will check whether the **ENABLE_REDIRECTS_MIDDLEWARE** flag is set or not, if so, the file name will be changed to **middleware.ts** and nextjs will know how to automatically deal with it. ## How to test it? I created a [PR](vtex-sites/starter.store#599) with the flag enabled, clone the branch and then: - Run `yarn build` - check if the **middleware.ts** was created inside **.faststore/src** ### References https://docs.google.com/document/d/1iC1fLwJbypnvDyp_JilKBfQfaHjFDHYrjS1kC722sB4/edit?tab=t.0#heading=h.tglo77yl0lf5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
How it works?
How to test it?
Starters Deploy Preview
References
Checklist
You may erase this after checking them all 😉
PR Title and Commit Messages
feat,fix,chore,docs,style,refactorandtestPR Description
breaking change,bug,contributing,performance,documentation..Dependencies
yarn.lockfile when there were changes to the packages