fix: Minor accessibility warnings #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-64fb2f8--nextjs.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 38b5f7f
|
We already print the description of the violation, but it's not immediately clear which element is causing it. e.g. in https://github.com/vtex-sites/nextjs.store/pull/141/checks?check_run_id=7010437942 we had a color contrast violation but no pointer which element is causing it.
Attempt to fix [this][1] flaky axe's accessibility issue of color contrast. Apparently because the input is not totally hidden, it's getting picked up by axe and failing the color contrast check because there's no text and due the small dimension (0 width). Setting the opacity to 0 seems to fix and there seems to be no visual/functional drawback. dequelabs/axe-core#3514 [1]: https://github.com/vtex-sites/nextjs.store/runs/7015698254#:~:text=description%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%E2%94%82%20nodes%20%E2%94%82%0A%E2%94%9C%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%BC%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%BC%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%BC%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%BC%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%80%E2%94%A4%0A%E2%94%82%20%20%20%200%20%20%20%20%E2%94%82%20%27-,color%2Dcontrast,-%27%20%E2%94%82%20%27serious%27%20%E2%94%82%20%27Ensures%20the
filipewl
commented
Jun 23, 2022
| @@ -37,6 +37,15 @@ function logToTerminal(violations) { | |||
| nodes: nodes.length, | |||
| })) | |||
| ) | |||
| for (const violation of violations) { | |||
There was a problem hiding this comment.
Example of this new log. Hoping it can help us to better pinpoint the elements with the issues.
icazevedo
approved these changes
Jun 27, 2022
There was a problem hiding this comment.
Terrific work, Filipe. I tried really hard to read the table you linked on item 2, but I couldn't understand it. I tried reading the description of the table above it, but still, I couldn't figure out what each column means and how this affects what you did here. Maybe we can meet to discuss this later on?
Our Hero component makes use of a header element with an aria-labelledby attribute, but that's not a valid combination because the header has no role when it's a descendant of an article.
|
Welll doneee! This will be so helpful @filipewl 😍😍😍 Regarding the 2 warning left:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Fix some minor accessibility warnings reported by axe DevTools:
navelements that are used in the footer's links are considered landmarks and all landmarks must have a unique accessible name.Herocomponent makes use of aheaderelement with anaria-labelledbyattribute, but that's not a valid combination because theheaderhas no role when it's a descendant of anarticle.There are still going to be 2 warnings left being reported by axe:
PaymentMethodscomponent inside@faststore/ui.Incentivescomponent.References