Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/change url product when update wishlist #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

PedroPaivaDev
Copy link
Contributor

The updateWishlist resolver was adapted to make a request to the vtex product api, in order to retrieve the product link returned by it and then store it in the product data on the wishlist. The link returned has the domain portal.vtexcommercestable.com.br, which is then handled by the 'getProductPath' function, which in turn will return the correct url when it is in the IO or faststore.

Currently, the wishlist block only uses a single “updateWishList” resolver for all the “add product to wishlist”, “update wishlist” and “remove item from wishlist” actions, so this request to get the product link will be executed in all these actions.

I've also made some adjustments to the variable names to make the code easier to read.

Copy link

vtex-io-ci-cd bot commented Oct 9, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@PedroPaivaDev
Copy link
Contributor Author

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)
  • Minor (backwards-compatible functionality)
  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@PedroPaivaDev PedroPaivaDev marked this pull request as ready for review October 9, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant