-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix locale and holiday days #76
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
343dae8
to
29e12a5
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4aae227
a2e4320
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
Cy-Runner
Cypress Dashboard
Success
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving? #changingTooling
the current version of the App has the Month Intl hardcoded to US, making the month and the format non compatible with outside regions.
Additional to this, it is adding 1 day to the holidays set on the pickuppoint making it invalid for customers.
front end:
Admin configuration:
this PR is adding the Locale and removing the additional date to respect the pickup point settings
How to test it?
https://cesar--embargosalobestia.myvtex.com/tiendas/embargosalobestia-alhama-de-murcia-murcia-30840/PP_ALHAMA
Screenshots or example usage: