Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix locale and holiday days #76

Merged
merged 9 commits into from
Nov 6, 2023
Merged

fix locale and holiday days #76

merged 9 commits into from
Nov 6, 2023

Conversation

cesarocampov
Copy link
Contributor

@cesarocampov cesarocampov commented Dec 1, 2022

What problem is this solving? #changingTooling

the current version of the App has the Month Intl hardcoded to US, making the month and the format non compatible with outside regions.
Additional to this, it is adding 1 day to the holidays set on the pickuppoint making it invalid for customers.

front end:
Screenshot 2022-12-01 at 12 51 55

Admin configuration:
Screenshot 2022-12-01 at 12 58 28

this PR is adding the Locale and removing the additional date to respect the pickup point settings

How to test it?

https://cesar--embargosalobestia.myvtex.com/tiendas/embargosalobestia-alhama-de-murcia-murcia-30840/PP_ALHAMA

Screenshots or example usage:

Screenshot 2022-12-01 at 12 57 34

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Dec 1, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Warnings
⚠️

🛑 This PR will change tooling [💡 could be GitHub Actions, package.json, etc]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 8, PR deletions = 7

Generated by 🚫 dangerJS against b7760aa

Git-the-Sanz
Git-the-Sanz previously approved these changes Dec 2, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

diegoleone
diegoleone previously approved these changes Dec 2, 2022
beatrizmaselli
beatrizmaselli previously approved these changes Oct 5, 2023
Copy link
Collaborator

@beatrizmaselli beatrizmaselli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beatrizmaselli beatrizmaselli dismissed stale reviews from Git-the-Sanz, diegoleone, and themself via 4aae227 October 10, 2023 11:43
@diegoleone diegoleone self-requested a review October 16, 2023 13:14
diegoleone
diegoleone previously approved these changes Oct 16, 2023
beatrizmaselli
beatrizmaselli previously approved these changes Oct 16, 2023
@beatrizmaselli beatrizmaselli dismissed stale reviews from diegoleone and themself via a2e4320 November 6, 2023 17:25
beatrizmaselli
beatrizmaselli previously approved these changes Nov 6, 2023
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Copy link

github-actions bot commented Nov 6, 2023

Cy-Runner

 [✓] Execution time
  -  initWorkspace................. 00:00:04
  -  installApps................... 00:00:06
  -  uninstallApps................. 00:00:03
  -  linkApp....................... 00:00:30
  -  strategy...................... 00:00:43
  -  teardown...................... 00:00:15
  -  total......................... 00:01:48

Cypress Dashboard

 [✓] https://cloud.cypress.io/projects/svuskc/runs/338

Success

 [✓] The test ran successfully, well done!

@beatrizmaselli beatrizmaselli merged commit bebeee7 into master Nov 6, 2023
13 checks passed
@beatrizmaselli beatrizmaselli deleted the fix/locale-holiday branch November 6, 2023 19:14
Copy link

vtex-io-ci-cd bot commented Nov 6, 2023

Your PR has been merged! App is being published. 🚀
Version 0.10.15 → 0.11.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants