Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined country list #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sahanljc
Copy link

@sahanljc sahanljc commented Aug 1, 2022

What problem is this solving?

This PR handles the country list being undefined until the list is loaded.

Type of changes

✔️ Type of Change
✔️ Bug fix
_ New feature
_ Breaking change
_ Technical improvements

@sahanljc sahanljc requested a review from a team as a code owner August 1, 2022 13:26
@sahanljc sahanljc requested review from lucasecdb and wdsrocha and removed request for a team August 1, 2022 13:26
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Aug 1, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants