Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Organization Setting "Full Impersonation" #175

Merged
merged 4 commits into from
Oct 16, 2024

Conversation

wender
Copy link
Collaborator

@wender wender commented Oct 8, 2024

What problem is this solving?

Our client needs to allow Customer support to impersonate a user and be able to switch between the user's Organization.

How to test it?

  • Head over to https://wender--kevinyeebiz.myvtex.com/
  • Add to your admin user access to Call Center Operator
  • Now, back to the Home Page, impersonate the user [email protected] (that belongs to more than one organization)
  • After reloading, click My Organization; initially, you won't be able to switch to a different Organization
  • Now head over to the Organization Admin, Settings tab, Enable and Save "Full Impersonation"
  • Head back to the home page and open the My Organization dropdown
  • You should now be able to switch

[Workspace](Link goes here!)

Screenshots or example usage:

Impersonating
image

My Organization, without Full Impersonation
image

Organization Settings
image

After the change
image

Describe alternatives you've considered, if any.

Related to / Depends on

vtex-apps/b2b-organizations-graphql#180

…itch between the User's Organization/Cost Center
Copy link

vtex-io-ci-cd bot commented Oct 8, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Oct 8, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@wender wender requested a review from enzomerca October 8, 2024 23:14
Copy link

github-actions bot commented Oct 8, 2024

Warnings
⚠️

Looks like this PR is too large [:bulb: smaller PRs are easy to review and approve]

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 105, PR deletions = 37

Generated by 🚫 dangerJS against 74f6001

Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A general comment:
"Full Impersonation" seems a bit to generic to show on the settings UI, no? Should we change to something like: "Allow Organization and Cost Center selection while impersonating"?
The code itself might reference that as "Full Impersonation", but on the UI it might be a bit misleading.

@wender wender requested a review from enzomerca October 9, 2024 20:17
Copy link

sonarcloud bot commented Oct 16, 2024

@enzomerca enzomerca merged commit a121cd4 into master Oct 16, 2024
16 checks passed
@enzomerca enzomerca deleted the feature/added-full-impersonation branch October 16, 2024 15:06
Copy link

vtex-io-ci-cd bot commented Oct 16, 2024

Your PR has been merged! App is being published. 🚀
Version 1.35.2 → 1.36.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants