Merge pull request #152 from vtex-apps/fix/cost-center-address-entrie…

…s-error Fix getCostCenterById error when not found
vtex-apps · Mar 28, 2024 · 869c067 · 869c067
2 parents ad1fd29 + 0487b51
commit 869c067
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+### Fix
+
+- Fix getCostCenterById query when the cost center is not found
+
 ## [0.49.0] - 2024-03-20
 
 ### Added

diff --git a/node/resolvers/Queries/CostCenters.ts b/node/resolvers/Queries/CostCenters.ts
@@ -96,7 +96,10 @@ const costCenters = {
         id,
       })
 
-      result.addresses = await addMissingAddressIds(result, ctx)
+      /* MasterData client returns empty string when it doesn't find the document */
+      if ((result as unknown as string) !== '') {
+        result.addresses = await addMissingAddressIds(result, ctx)
+      }
 
       return result
     } catch (error) {