Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes querystring problem #372

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).

## [Unreleased]
### Fixed
- Prevents redirect querystring to change order

## [4.37.0] - 2021-02-09
- Adds support for multi binding for redirect CSV managment
Expand Down
9 changes: 5 additions & 4 deletions react/RedirectForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import Loader from './components/Loader'
import Redirect from './queries/Redirect.graphql'
import TenantInfoQuery from './queries/TenantInfo.graphql'
import { getStoreBindings } from './utils/bindings'
import { parseRedirectQueryString } from './components/admin/redirects/utils'

interface CustomProps {
params: {
Expand Down Expand Up @@ -94,14 +95,14 @@ class RedirectForm extends Component<Props, State> {
if (!formData) {
try {
const rawQuerystring = history?.location?.search ?? ''
const querystring = queryString.parse(rawQuerystring)
const { binding, ...rest } = querystring
const restQuerystring = queryString.stringify(rest)
const { binding, q } = queryString.parse(rawQuerystring)
const restQueryString =
typeof q === 'string' && parseRedirectQueryString(q)
const response = await client.query<RedirectQuery>({
query: Redirect,
variables: {
path: `/${params.path}${
restQuerystring ? '?' + restQuerystring : ''
restQueryString ? '?' + restQueryString : ''
}`,
binding: binding,
},
Expand Down
11 changes: 9 additions & 2 deletions react/components/admin/redirects/List/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { Binding } from 'vtex.tenant-graphql'

import { getFormattedLocalizedDate } from '../../../../utils/date'
import { BASE_URL, NEW_REDIRECT_ID } from '../consts'
import { slugifyRedirectQueryString } from '../utils'
import CreateButton from './CreateButton'
import { messages } from './messages'

Expand Down Expand Up @@ -130,11 +131,17 @@ const List: React.FC<Props> = ({
const handleItemView = useCallback(
(event: { rowData: Redirect }) => {
const selectedItem = event.rowData
const bindingQS = selectedItem.from.includes('?')
const hasQueryString = selectedItem.from.includes('?')
const bindingQueryString = hasQueryString
? `&binding=${selectedItem.binding}`
: `?binding=${selectedItem.binding}`
const [itemFrom, itemQueryString] = hasQueryString
? selectedItem.from.split('?')
: [selectedItem.from, '']
const parsedQueryString =
itemQueryString && `?q=${slugifyRedirectQueryString(itemQueryString)}`
navigate({
to: `${BASE_URL}${selectedItem.from}${bindingQS}`,
to: `${BASE_URL}${itemFrom}${parsedQueryString}${bindingQueryString}`,
})
},
[navigate]
Expand Down
5 changes: 5 additions & 0 deletions react/components/admin/redirects/utils.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
export const slugifyRedirectQueryString = (data: string) =>
data.replace(/=/g, '/').replace(/&/g, ';')

export const parseRedirectQueryString = (data: string) =>
data.replace(/\//g, '=').replace(/;/g, '&')