Better messages if source language is unknown

As a follow-up to 2d62116, differentiate the two cases when pre-translation can't be done: use of symbolic IDs and unknown source language. Provide separate explanations for both.
vslavik · Aug 1, 2023 · 1338bc2 · 1338bc2
1 parent 8034c28
commit 1338bc2
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 2 deletions.
diff --git a/src/pretranslate.cpp b/src/pretranslate.cpp
@@ -151,7 +151,7 @@ int PreTranslateCatalog(wxWindow *window, CatalogPtr catalog, const PreTranslate
 
 void PreTranslateWithUI(wxWindow *window, PoeditListCtrl *list, CatalogPtr catalog, std::function<void()> onChangesMade)
 {
-    if (catalog->UsesSymbolicIDsForSource() || !catalog->GetSourceLanguage().IsValid())
+    if (catalog->UsesSymbolicIDsForSource())
     {
         wxWindowPtr<wxMessageDialog> resultsDlg(
             new wxMessageDialog
@@ -166,6 +166,21 @@ void PreTranslateWithUI(wxWindow *window, PoeditListCtrl *list, CatalogPtr catal
         resultsDlg->ShowWindowModalThenDo([resultsDlg](int){});
         return;
     }
+    else if (!catalog->GetSourceLanguage().IsValid())
+    {
+        wxWindowPtr<wxMessageDialog> resultsDlg(
+            new wxMessageDialog
+                (
+                    window,
+                    _("Cannot pre-translate from unknown language."),
+                    _("Pre-translate"),
+                    wxOK | wxICON_ERROR
+                )
+        );
+        resultsDlg->SetExtendedMessage(_(L"Pre-translation requires that source text’s language is known. Poedit couldn’t detect it in this file."));
+        resultsDlg->ShowWindowModalThenDo([resultsDlg](int){});
+        return;
+    }
 
     wxWindowPtr<wxDialog> dlg(new wxDialog(window, wxID_ANY, _("Pre-translate"), wxDefaultPosition, wxSize(PX(440), -1)));
     auto topsizer = new wxBoxSizer(wxVERTICAL);

diff --git a/src/sidebar.cpp b/src/sidebar.cpp
@@ -876,11 +876,16 @@ void SuggestionsSidebarBlock::UpdateSuggestionsForItem(CatalogItemPtr item)
     m_pendingQueries = 0;
 
     // FIXME: Get catalog info from `item` once present there
-    if (m_parent->GetCatalog()->UsesSymbolicIDsForSource() || !m_parent->GetCatalog()->GetSourceLanguage().IsValid())
+    if (m_parent->GetCatalog()->UsesSymbolicIDsForSource())
     {
         SetMessage("SuggestionErrorTemplate", _(L"Translation suggestions require that source text is available. They don’t work if only IDs without the actual text are used."));
         return;
     }
+    else if (!m_parent->GetCatalog()->GetSourceLanguage().IsValid())
+    {
+        SetMessage("SuggestionErrorTemplate", _(L"Translation suggestions require that source text’s language is known. Poedit couldn’t detect it in this file."));
+        return;
+    }
 
     auto srclang = m_parent->GetCurrentSourceLanguage();
     auto lang = m_parent->GetCurrentLanguage();