Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI Improvements #80

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Add CI Improvements #80

merged 1 commit into from
Sep 2, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Aug 28, 2024 •
edited
Loading

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the patch label Aug 28, 2024
@Kidswiss Kidswiss force-pushed the add/ci_improvement branch from b1b9ec4 to c08a89b Compare August 28, 2024 13:57
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team August 28, 2024 14:16
zugao
zugao approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was tested on your local machine right? Also isn't this almost the same between all repos?

@Kidswiss Kidswiss force-pushed the add/ci_improvement branch 9 times, most recently from 657dfa6 to 06021d3 Compare September 2, 2024 07:00
@Kidswiss Kidswiss merged commit fb02ceb into master Sep 2, 2024
7 checks passed
@Kidswiss Kidswiss deleted the add/ci_improvement branch September 2, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zugao zugao zugao approved these changes

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee was automatically assigned from vshn/schedar

@wejdross wejdross Awaiting requested review from wejdross wejdross was automatically assigned from vshn/schedar

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kidswiss @zugao