Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Stackgres versions > 1.5.0 #20

Closed
wants to merge 36 commits into from
Closed

Conversation

wejdross
Copy link
Member

@wejdross wejdross commented Jan 5, 2024

  • upgrading component, so it's possible to use Stackgres versions greater than 1.5.0
  • changing default Stackgres version to 1.7

Breaking changes:

  • impossible to use with Stackgres < 1.6.0

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@wejdross wejdross added breaking enhancement New feature or request labels Jan 5, 2024
@wejdross wejdross requested a review from TheBigLee January 5, 2024 12:33
@TheBigLee TheBigLee requested a review from Kidswiss January 5, 2024 12:38
@Kidswiss
Copy link
Contributor

Kidswiss commented Jan 5, 2024

Please test this with ArgoCD first.

From my personal experience on my homelab we need a bit of post processing to make it really work with ArgoCD:

app.jsonnet we need to change the app to ServerSideApply=true or otherwise it can't deploy the CRDs. Also, we need to ignore the caBundles in the webhook configs, otherwise the webhooks will break:

  syncPolicy:
    automated: {}
    syncOptions:
      - ServerSideApply=true
 ...
  ignoreDifferences:
  - group: apps
    kind: Deployment
    jsonPointers:
    - /spec/replicas
  - group: admissionregistration.k8s.io
    kind: ValidatingWebhookConfiguration
    jqPathExpressions:
    - '.webhooks[]?.clientConfig.caBundle'
  - group: admissionregistration.k8s.io
    kind: MutatingWebhookConfiguration
    jqPathExpressions:
    - '.webhooks[]?.clientConfig.caBundle'

There were a few other minor things that I had to adjust as they never got in sync, but I'm not sure what it was.

@wejdross wejdross force-pushed the upgrade/helm_versions branch from 3a1e8f4 to eabe2d2 Compare January 9, 2024 10:45
@wejdross wejdross force-pushed the upgrade/helm_versions branch 5 times, most recently from 8519c3e to 14313a9 Compare January 10, 2024 13:20
@wejdross wejdross force-pushed the upgrade/helm_versions branch from 14313a9 to efee3c7 Compare January 10, 2024 13:22
component/app.jsonnet Outdated Show resolved Hide resolved
postprocess/null.jsonnet Outdated Show resolved Hide resolved
@wejdross wejdross requested a review from TheBigLee January 11, 2024 16:28
@wejdross wejdross force-pushed the upgrade/helm_versions branch from 441135e to d0cd3d0 Compare January 11, 2024 16:30
@wejdross
Copy link
Member Author

@Kidswiss @TheBigLee please take a look, especially on clusterrolebinding and role files, I added them very low numbers so they are applied earlier rather than latyer, they also share argo PreSync hook.

it should be now sufficient. What I've found out during migration so far:

  • secret name differs, the one responsible for setting password - whole cleartextpassword script - adjusted
  • null entries must be deleted otherwise argoCD breaks
  • we need to clean secrets, clusterroles, issuers and certs before migrating from 1.5 -> 1.7
  • we need to tell argo to ignore some fields, mostly defaults being set or it start to -> done in app.jsonnet

@wejdross wejdross force-pushed the upgrade/helm_versions branch from d0cd3d0 to 589bdf9 Compare January 11, 2024 16:49
@wejdross
Copy link
Member Author

wejdross commented Jan 17, 2024

guys, please check new feature to restart operator and restapi during sync - tested it on lab, and besides minimal downtime (~60-90seconds) everything is green afterwards

@wejdross wejdross force-pushed the upgrade/helm_versions branch from 647dd98 to f966ffe Compare January 18, 2024 09:30
@wejdross wejdross force-pushed the upgrade/helm_versions branch from f966ffe to 37b4f81 Compare January 18, 2024 09:59
@wejdross wejdross force-pushed the upgrade/helm_versions branch from 15d3e3c to 36f1b29 Compare January 18, 2024 11:39
[email protected] and others added 5 commits January 18, 2024 13:48
Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee force-pushed the upgrade/helm_versions branch from b8c4863 to ee43911 Compare January 18, 2024 14:11
@TheBigLee TheBigLee force-pushed the upgrade/helm_versions branch 10 times, most recently from ae77076 to 87abf0b Compare January 18, 2024 18:08
f
Signed-off-by: Nicolas Bigler <[email protected]>
@TheBigLee TheBigLee force-pushed the upgrade/helm_versions branch from 87abf0b to a251c46 Compare January 18, 2024 19:03
@TheBigLee TheBigLee closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants