Skip to content

Allow descriptor sets to be inherited even if the pipeline layout isn't exactly identical #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AnyOldName3
Copy link
Contributor

Pull Request Template

Description

Vulkan only requires the pipeline layout used to bind descriptor sets to be compatible for the push constants and descriptor sets up to the one that's being bound. Descriptor sets after the one being bound don't make a difference. That means you can have nice things like shared descriptor sets in early slots that work with multiple pipelines with distinct layouts and don't need to rebind them.

Previously, the GraphicsPipelineConfigurator would only allow inherited state with an equivalent pipeline layout rather than just requiring it to match the subset that mattered. This makes it so descriptor sets can be inherited if their layout is compatible for that descriptor set.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

It's a quasi-fix-feature-optimisation combo change. Someone might consider the previous overly strict requirements to be a bug, but it's not like there was documentation saying they did something else. It doesn't necessarily make anything faster unless applications are set up so that it can. Some might be, as the VSG's built-in PBR and Phong shadersets have compatible view descriptor sets, so something using both together and inheriting one will see it start working for the other, too.

How Has This Been Tested?

Mostly it's been tried with the not-yet-merged vsgincompatiblepipelinelayouts example as this work is a precursor to one of the potential fixes which we probably want to merge even if we don't go for that fix in the end.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant