fix URR to be (really) complete also under AVATAR #507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following will happily saturate and report SAT (on an unsat problem)
(on your machine, the random seed might need to be altered, but the problem is small and the probability of trouble quite high).
The issue is that we work with binary_resolution = off and urr as the saving grace of completeness for a Horn problem (which SYN941+1 is). URR implements a heuristic which makes it happy on generating the first empty clauses from a given parent. However, in this case, we need all the urr resolvents to close all the AVATAR branches.
This PR adds an option to skip the mentioned heuristic (urr=full) and also updates
Options::complete
to properly reflect when we are complete and when not. Newly, the above reports