Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve change detection & fix multi-tabs demo example #56

Merged
merged 4 commits into from
Jan 17, 2024

Conversation

voznik
Copy link
Owner

@voznik voznik commented Jan 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

voznik added 3 commits January 9, 2024 17:31
- update rxdb to latest
- bump Angular peerDep to min 14
- fix rxjs peerDep
// Collection
- use angular inject for DI in collection service (min 14)
- improve typings & work with local documents, return json instead rxdoc
- presist/restore local doc to/from URL via angular router
- simplify examples with this new local persist
- fix usage of local docs in signals (filter example)
@voznik voznik force-pushed the fix/change-detection branch from 0ed0ad9 to 6b3a61f Compare January 17, 2024 14:55
@voznik voznik force-pushed the fix/change-detection branch from 154e2d5 to 9515037 Compare January 17, 2024 16:07
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

6.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@voznik voznik merged commit 312d197 into master Jan 17, 2024
@voznik voznik deleted the fix/change-detection branch January 17, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant