Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pipeline to release plugin. #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wildone
Copy link

@wildone wildone commented Jul 6, 2021

add a matrixed pipeline to create a release with plugin artifacts.

@@ -1 +1,2 @@
t/servroot
/.idea/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't include your local editor ignores in the repo. Use git config --global core.excludesFile.

runs-on: ubuntu-latest
strategy:
matrix:
nginx: [ '1.21.0', '1.21.1' ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't we use latest stable release too? (and latest mainline release)

Suggested change
nginx: [ '1.21.0', '1.21.1' ]
nginx: [ '1.22.0', '1.21.6' ]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw the PR date and understood why those were the versions :)

- name: Checkout source
uses: actions/checkout@v2
with:
repository: 'nginx/nginx' #release-1.21.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we don't have to repeat ourselves each time upgrading nginx.

Suggested change
repository: 'nginx/nginx' #release-1.21.1
repository: 'nginx/nginx'

@u5surf
Copy link
Collaborator

u5surf commented Sep 3, 2022

Hi, @wildone
Thanks for your contribute!
This issue has been long abandone,
but also this modules has no continuous integration, that why I made another PR to resume stagnated development of this module.
#238

Does it could coexist your proposed actions? or if it couldn't, I consider it could be satisfied to integrate your PR. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants