-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MS Teams to chatops #151
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions before this can be approved
@tmu-sprd anything else you're waiting on before we merge this? |
@dhollinger I'm currently preparing a unit test for the teams function. Should be done this week. |
@dhollinger Added unit test for teams. My changes are done and ready for review. Thanks a lot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Great work on the new feature!
This PR adds the ability to send notifications to Microsoft Teams. Currently Slack and RocketChat are supported.
The notifications are sent via an AdaptiveCard. The messages are colored: green for successful, red for errors and orange, if there are warnings in the r10k output.
The PostMessage function is extended to add the output of r10k hidden underneath a "Details" button.
This is the first time, I did something in Go. If there is something to improve, I'm happy for suggestions.