modulesync 7.0.0 #874
Merged
modulesync 7.0.0 #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only failures are from the "new" OSes which were not tested before. I am inclined to merging this as-is and then following up with fixes for Oracle. |
ekohl
approved these changes
Oct 3, 2023
| @@ -87,7 +87,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| if ($facts['os']['release']['major'] == '7' and versioncmp($zabbix_version, '5.0') >= 0) { | |||
| if ($facts['os']['name'] == 'CentOS' and $facts['os']['release']['major'] == '7' and versioncmp($zabbix_version, '5.0') >= 0) { | |||
There was a problem hiding this comment.
Will this also affect RHEL? If you're running RHEL, you probably don't want CentOS SCL bits, but it can break some environments.
There was a problem hiding this comment.
There is no such package in RHEL, so it was broken before already.
There was a problem hiding this comment.
Oh yes, with Foreman we had copied it in our repos so it worked for other OSes (IIRC mostly for Scientific Linux).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.