Replace deprecated shell_escape function with stdlib::shell_escape
#480
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For stdlib 9.x and later, the shell_escape function has been moved to stdlib::shell_escape. This change breaks compatiblity with stdlib 8.x
kenyon
requested changes
Jul 20, 2024
kenyon
changed the title
shell_escape function
ekohl
changed the title
shell_escape functionshell_escape function with stdlib::shell_escape
This is due to stdlib functions such as shell_escape being rescoped to the stdlib namespace in stdlib 9.0.0
kenyon
approved these changes
Jul 22, 2024
smortex
approved these changes
Jul 23, 2024
TheMeier
approved these changes
Jul 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
For stdlib 9.x and later, the shell_escape function has been moved to stdlib::shell_escape.
This change breaks compatiblity with stdlib 8.x
This Pull Request (PR) fixes the following issues
Fixes #479