Don't allow ensure=file anymore for systemd::unit_file #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baurmatt
changed the title
|
Might also be better to preserve backwards compatibility by just treating |
@cocker-cc correctly mentioned in 7f63dfa#commitcomment-139614892 that after #405 `ensure=file` breaks due to `stdlib::ensure` not being able to handle that. As `file` is any way only a synonym for `present`, let's just remove it from the possible values.
baurmatt
force-pushed
the
unit_file_ensure
branch
from
df1d762 to
24789f3
Compare
|
@kenyon Thanks for the review! I've update Regarding the backwards compatibility: I thought a lot about it. But i feels like a bad UX to have I've also git blamed it back to the source -> https://github.com/voxpupuli/puppet-systemd/blame/b80984882b79c4edb48486513be1436dfa6736f2/manifests/unit_file.pp |
|
@baurmatt I agree with your analysis, this is a good change. |
TheMeier
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
@cocker-cc correctly mentioned in
7f63dfa#commitcomment-139614892 that after #405
ensure=filebreaks due tostdlib::ensurenot being able to handle that. Asfileis any way only a synonym forpresent, let's just remove it from the possible values.This Pull Request (PR) fixes the following issues
7f63dfa#commitcomment-139614892