Add more security related parameters to service #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkck24
force-pushed
the
Add-more-security-options
branch
2 times, most recently
from
5d3e434 to
94c1cda
Compare
smortex
reviewed
Oct 5, 2023
types/unit/service.pp
Outdated
| Stdlib::Unixpath,Pattern[/-\/.+/], | ||
| Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1], | ||
| ], | ||
| Optional['EnvironmentFile'] => Variant[Stdlib::Unixpath,Pattern[/-\/.+/], Array[Variant[Stdlib::Unixpath,Pattern[/-\/.+/]],1]], |
There was a problem hiding this comment.
Why this change? Other parameter seems to use the same data type (BindPaths, BindReadOnlyPaths, maybe others), maybe it make sense to add another custom type for this?
There was a problem hiding this comment.
I reverted the change
lkck24
force-pushed
the
Add-more-security-options
branch
3 times, most recently
from
d59f09e to
228e4fe
Compare
lkck24
force-pushed
the
Add-more-security-options
branch
from
228e4fe to
f642ec5
Compare
|
I have no idea why OL7 tests are failing. But it does not look like it is related to my change. |
|
the OL7 repo is broken and causes our tests to fail :( Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This PR adds more security related parameters to service unit.
This Pull Request (PR) fixes the following issues
Fixes #378