Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

$targetfile in puppetserver::config::bootstrap doesn't respect puppetserver 5.1.x #52

Open
Phil-Friderici opened this issue Feb 14, 2018 · 5 comments · May be fixed by #54
Open

$targetfile in puppetserver::config::bootstrap doesn't respect puppetserver 5.1.x #52

Phil-Friderici opened this issue Feb 14, 2018 · 5 comments · May be fixed by #54

Comments

@Phil-Friderici
Copy link
Contributor

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: puppet-agent-5.3.4-1.el7.x86_64 & puppetserver-5.1.5-1.el7.noarch
  • Ruby: 2.0.0
  • Distribution: CentOS Linux release 7.4.1708 (Core)
  • Module version: 3.0.0

How to reproduce (e.g Puppet code you use)

use puppetserver 5.1.5

What are you seeing

$targetfile in puppetserver::config::bootstrap is set to '/etc/puppetlabs/puppetserver/bootstrap.cfg' in dependency of the puppet agent version.

What behaviour did you expect instead

puppetserver 5.1.5 is using '/etc/puppetlabs/puppetserver/services.d/ca.cfg' instead.
$targetfile should be choosen by dependency of the installed puppetserver version not the agent version.

Output log

no output, functionality is silently ignored when the file isn't existing

Any additional information you'd like to impart

workaround: create a symlink pointing to the new location.

The puppet agent version number is not conclusive to set puppetserver details.
If we don't have a fact for puppetserver version, $targetfile should become a parameter with the current default values. This way you could override the (now) outdated defaults.
@ghoneycutt
Copy link
Member

Thank you @Phil-Friderici for reporting this! Could you send a pull request to address the issue?

@Phil-Friderici Phil-Friderici linked a pull request Feb 15, 2018 that will close this issue
Open
@Phil-Friderici
Copy link
Contributor Author

here we go #54

@Phil-Friderici Phil-Friderici mentioned this issue Mar 1, 2018
Open
@jardleex
Copy link

jardleex commented Mar 5, 2018

We also see this issue with:

  • Puppet: puppet-agent-1.10.10-1xenial & puppetserver-2.8.1-1puppetlabs1

Here the path also should be '/etc/puppetlabs/puppetserver/services.d/ca.cfg'.
We're running this module on tag 2.1.0.

@Phil-Friderici
Copy link
Contributor Author

@jardleex until this is fixed, you can use a symlink as workaround.

@jardleex
Copy link

jardleex commented Mar 6, 2018

Thanks for the hint. Did it this way right away, works very well.

file { 'symlink_bootstrap_cfg':
        ensure  => link,
        path    => '/etc/puppetlabs/puppetserver/bootstrap.cfg',
        target  => '/etc/puppetlabs/puppetserver/services.d/ca.cfg',
        require => Package['puppetserver'],
      }

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameterize targetfile in puppetserver::config::bootstrap Phil-Friderici/puppet-puppetserver
3 participants
@ghoneycutt @Phil-Friderici @jardleex