V4 #135
Open
V4 #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will require a major version change as it will break compatibility. It manages a setting in the main section, which is on the agent side and should not have been specified in the master section which happens with the puppet::server class.
CA is now managed by /etc/puppetlabs/puppetserver/services.d/ca.cfg https://docs.puppet.com/puppetserver/2.7/configuration.html#service-bootstrapping
In response to the following warning from puppetserver-daemon.log: OpenJDK 64-Bit Server VM warning: ignoring option MaxPermSize=256m; support was removed in 8.0
|
fixes #136 |
| @@ -81,6 +74,16 @@ | |||
| notify => Service['puppetserver'], | |||
| } | |||
|
|
|||
| file { 'puppetserver_ca_cfg': | |||
| ensure => 'file', | |||
| path => '/etc/puppetlabs/puppetserver/services.d/ca.cfg', | |||
There was a problem hiding this comment.
Only if you want to support older puppetserver versions the path needs to be parameterized.
See voxpupuli/puppet-puppetserver#52 for details.
|
For a v4 release I would suggest to drop support of stringified bools ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.