-
-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase lower bounds for stdlib, vcsrepo #327
Conversation
Hello @kenyon, I'm not sure puppet/puppetboard is compatible with puppet/python >= 6 as we still find
Also, I tested with your PR and that's what I'm getting (with
Here, I see two solutions for that (I'm not a puppet expert, maybe I wrong but I try to add some ideas):
|
Indeed, I did not look for such incompatibilities. I figured we could find and fix those in other pull requests. So if you could submit a PR that would be great. 👍 |
be8bebb
to
791732d
Compare
Don't know why travis times out trying to download the puppetdb module. Maybe it needs puppetlabs/puppetlabs-puppetdb#327 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After review of the differences which where part of #317, it seems two lower bounds where not included and if applicable, we can update this PR to fix this.
Closes #326.