Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow initial content for virtual and transport if mta is true #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edrude
Copy link
Contributor

@edrude edrude commented Aug 2, 2024

Pull Request (PR) description

I have over 1,500 virtual aliases and if I add them to virtual a la the postfix::virtual defined type puppet runs take a very long time. Also, when I remove an item I want it to actually be removed from my postfix configs too without having to leave it in my data with an ensure absent.

This change allows a user to provide initial seed content to the virtual and transport hashes that are created if you set mta to true. This way, current functionality is maintained, but if you opt to you can build your own content for virtual or transport outside of the module and bring it in.

…sport files that will be setup if you set mta to true
@edrude
Copy link
Contributor Author

edrude commented Aug 5, 2024

I'm starting to wonder if this takes the module in the wrong direction. I could probably just set mta to false, then "manually", in my own puppet code, setup a system as an mta using lower level constructs from this module. Perhaps mta and satellite are better viewed as opinionated option sets that may or may not be useful for a given site.

For the sake of keeping the module simpler the above may be the way to go. Maybe I end up with some documentation update suggestions instead of code additions.

At least that's what my brain is telling me at 1AM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant