Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http_raw_prepend/append indentation #1608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matejzero
Copy link

Pull Request (PR) description

http_raw_prepend and http_raw_append have wrong indentation. Example with current template:

  ssl_stapling_verify       off;

    real_ip_header X-Forwarded-For;
    set_real_ip_from 1.2.3.4;

  include /etc/nginx/conf.d/*.conf;

This MR removes 2 extra spaces.

Copy link
Member

@kenyon kenyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this would cause a restart of the nginx service, IMO we should wait to merge this until we do a major release.

@matejzero
Copy link
Author

I can live with that, I think it's only a cosmetic fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants