Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modulesync 7.3.0 & puppet-lint adjustments #24

Merged
merged 40 commits into from
Feb 14, 2024
Merged

modulesync 7.3.0 & puppet-lint adjustments #24

merged 40 commits into from
Feb 14, 2024

Conversation

FlorentPoinsaut
Copy link
Member

No description provided.

@zilchms zilchms changed the title modulesync 5.0.1-13-gdbe966f modulesync 7.2.0 Feb 4, 2024
@zilchms zilchms mentioned this pull request Feb 4, 2024
Closed
@zilchms zilchms force-pushed the modulesync branch 4 times, most recently from 1995ac7 to 6b330d3 Compare February 6, 2024 14:37
@zilchms zilchms force-pushed the modulesync branch 3 times, most recently from 4465ff1 to 1b3f276 Compare February 13, 2024 00:21
@zilchms zilchms mentioned this pull request Feb 13, 2024
Merged
@zilchms zilchms force-pushed the modulesync branch 2 times, most recently from 819d581 to 27ebe32 Compare February 13, 2024 12:29
@zilchms zilchms mentioned this pull request Feb 13, 2024
Merged
@bastelfreak bastelfreak changed the title modulesync 7.2.0 modulesync 7.3.0 Feb 13, 2024
@bastelfreak bastelfreak changed the title modulesync 7.3.0 modulesync 7.3.0 & puppet-lint adjustments Feb 13, 2024
bastelfreak
bastelfreak reviewed Feb 13, 2024
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
ekohl
ekohl requested changes Feb 13, 2024
View reviewed changes
manifests/init.pp Outdated Show resolved Hide resolved
manifests/init.pp Show resolved Hide resolved
spec/classes/init_spec.rb Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
@zilchms zilchms mentioned this pull request Feb 13, 2024
Merged
ekohl
ekohl reviewed Feb 13, 2024
View reviewed changes
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/classes/init_spec.rb Outdated Show resolved Hide resolved
@zilchms zilchms mentioned this pull request Feb 13, 2024
Merged
@zilchms zilchms requested a review from ekohl February 13, 2024 15:58
ekohl
ekohl reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's starting to shape up nicely..

spec/classes/init_spec.rb Outdated Show resolved Hide resolved
spec/spec_helper_acceptance.rb Outdated Show resolved Hide resolved
ekohl
ekohl approved these changes Feb 14, 2024
View reviewed changes
spec/spec_helper_acceptance.rb Outdated Show resolved Hide resolved
@zilchms zilchms merged commit 14e1055 into master Feb 14, 2024
9 checks passed
@zilchms zilchms deleted the modulesync branch February 14, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilchms zilchms zilchms left review comments

@bastelfreak bastelfreak bastelfreak left review comments

@ekohl ekohl ekohl approved these changes

Assignees
No one assigned
Labels
modulesync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FlorentPoinsaut @zilchms @ekohl @bastelfreak @maxadamo